PSP branch?

Hi @Takumi.Matsunobu, @Fabian.Jakub ,

today the psp test failed. I was checking what happened and I couldn't find the psp branch in the DKRZ repository anymore.

Do you have any idea why that happened?

Wait, I was looking to the wrong repository...

It looks like the build error is related with the fact that they merged the master branch into psp.

  >> 1751    configure: error: in `.../spack-src/externals/yac':
  >> 1752    configure: error: libfyaml.h not found

Maybe they added a new dependency to yac that was not there before?

I'll try to figure it out.

It looks like adding libfyaml as a dependency and the corresponding flag for the link phase was enough.

For now I added that only for psp.

Two things:

• @Takumi.Matsunobu , were you aware that the psp version got updated with the newest content in master? Not sure if this will affect your simulations. Maybe we can consider having a tag or something to point to a specific static commit instead of a moving branch.
• @Fabian.Jakub , given that this dependency will be needed in any version after a certain revision, should we just add the dependency by default and just forget about it? Besides unnecessary, could it be a problem to add an unused dependency to older versions?

changed the description

Should not hurt. Btw who updated the psp branch? Currently only have my phone at hand and can't login to dkrz..

It looks like Albert de Lozar did it. Do you know him? Is there someone else besides us that use this branch? I still don't understand why last's week test didn't fail if the commit is from the 9th.

commit 274f09dce070e1379603b9054943545d6b173492 (HEAD -> icon-nwp/icon-nwp-psp, origin/icon-nwp/icon-nwp-psp)
Merge: cb2ccf0ece 49a906f2f7
Author: Alberto de Lozar <alberto.lozar-de@dwd.de>
Date:   Mon Oct 9 07:15:37 2023 +0000

    Merge branch 'master' into icon-nwp/icon-nwp-psp

I'll add the library as a generic dependency.

Hi @Oriol.Tinto , I was not notified that the PSP branch on DKRZ got updated. I know Alberto. He is testing the PSP scheme in the operational condition. No surprise if he merges latest updates to the psp branch.

Luckily I am using the PSP branch mirrored in my w2w-b3 gitlab repository, so my simulations will not be affected. Nevertheless, I agree it would be helpful if we can specify a specific tag or a commit. The psp branch will be continuously updated as long as it attracts an interest from DWD.

Great!

• @Fabian.Jakub , do you know if we can create tags in the dkrz repo or we must talk to somebody?
• @Takumi.Matsunobu should we tag the version before this last merge happened?

Never tried but it is just a named hash. Don't see why we couldn't. If give me a hash and a name I can tag it.

Can we tag a specific commit of a branch? If yes, the commit cb2ccf0ece15da3a27ebba8a3835bed77ffb8be3 of the psp branch is the version we will be using until June of next year.

Yes, we can. What would be an appropriate name for it?

I think icon-nwp/icon-2.6.5-psp is fine for all. Thanks!

Whups, Indeed they protected tags:

GitLab: You are not allowed to create this tag as it is protected.

So, no can't tag the version. But you can checkout the hash in your setup directly?

We have a dependency added when using psp:

    depends_on("petsc", when="@psp")

Should we then add the dependency manually at the build command? Somethink like should make the trick:

icon:
   version: cb2ccf0ece15da3a27ebba8a3835bed77ffb8be3
   build_cmd: "icon-nwp@%^ICON.VERSION%% %^SPACK.COMPILER% +petsc"

Well, it is a bit trickier than what I expected.

It turns out that when you use a specific hash, it tries to fetch de code with the class object, so there's no call to do_fetch(). It means that it works well if the user has passwordless access to the default source (ssh key for ssh or .netrc with token for https ) but it is not going to work when that there's no passworless access to the default source (when relying on the source= variant or the GITTOKEN workaround).

If we have only few cases that we want to tag, maybe we can just add them like @Fabian.Jakub suggested.

I added an icon-2.6.5-psp pointing to the commit that @Takumi.Matsunobu mentioned:

version("icon-2.6.5-psp", commit="cb2ccf0ece15da3a27ebba8a3835bed77ffb8be3")

Hi @Oriol.Tinto , thank you for working on this issue. Adding a full hash as you did will be enough for our use case. I will test if it works on our cluster next week.