Skip to content
Snippets Groups Projects
Commit 738da982 authored by Nikolai's avatar Nikolai
Browse files

Don't refit StandardScaler to test data

parent 99966d64
No related branches found
No related tags found
No related merge requests found
......@@ -183,8 +183,10 @@ class KerasROOTClassification:
self._scaler = StandardScaler()
logger.info("Fitting StandardScaler to training data")
self._scaler.fit(self.x_train)
logger.info("Fitting StandardScaler to test data")
self._scaler.fit(self.x_test)
# i think this would refit to test data (and overwrite the parameters)
# probably we either want to fit only training data or training and test data together
# logger.info("Fitting StandardScaler to test data")
# self._scaler.fit(self.x_test)
joblib.dump(self._scaler, filename)
return self._scaler
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment